PHP Help Needed :) - GoFuckYourself.com

Mamassita · 10-28-2011, 07:13 PM

Building a paid module for a custom tube script, but i'm getting this error

Notice: Undefined variable: paid in /home/nakedmov/public_html/xxx/video.php on line 179

Notice: Undefined variable: paid in /home/nakedmov/public_html/xxx/video.php on line 213

Line 179 to 187

PHP Code:


			
if($paid == false){

    if(isset($users_credits)){

        if($credits > $users_credits){

            $errors[] = 'Not enough credits for this action. Visit credits page from your profile to charge up your account!';

        }        

    } else {

        $errors[] = 'You need to login before you can watch this video';

    }    

}

Line 213

PHP Code:


			
$smarty->assign('paid',$paid);

Anyone know what i've done wrong ?

Thanks

FlexxAeon · 10-28-2011, 07:21 PM

dont think you use == for a boolean

try:

if($paid = false)

Mamassita · 10-28-2011, 07:23 PM

Quote:

Originally Posted by FlexxAeon

dont think you use == for a boolean

try:

if($paid = false)

Work like a charm

Thanks a lot

Aric · 10-28-2011, 07:32 PM

Quote:

Originally Posted by FlexxAeon

dont think you use == for a boolean

try:

if($paid = false)

I'm no expert, but that is wrong? You just assigned a value to $paid, which of course got rid of his PHP notices.

The PHP notices are displayed because $paid has no value set before the conditional.

VladS · 10-28-2011, 07:35 PM

PHP Code:


			
if(!$paid)

marlboroack · 10-28-2011, 07:38 PM

PHP Code:


			
my cock is huge

FlexxAeon · 10-28-2011, 07:39 PM

Quote:

Originally Posted by Aric

I'm no expert, but that is wrong? You just assigned a value to $paid, which of course got rid of his PHP notices.

The PHP notices are displayed because $paid has no value set before the conditional.

if it's under an if condition it's not setting a value

Mamassita · 10-28-2011, 07:40 PM

Quote:

Originally Posted by Aric

I'm no expert, but that is wrong? You just assigned a value to $paid, which of course got rid of his PHP notices.

The PHP notices are displayed because $paid has no value set before the conditional.

yeah seem there's no notices anymore

blackmonsters · 10-28-2011, 08:03 PM

Quote:

Originally Posted by Mamassita

Work like a charm

Thanks a lot

No it didn't.

Run these two scripts :

<?php

$paid = false;
if($paid = false) {
echo "This really works!";

}
else {
echo "No No No No!";
}

?>

-------------

<?php

$paid = false;
if($paid == false) {
echo "This really works!";

}
else {
echo "No No No No!";
}

?>

blackmonsters · 10-28-2011, 08:04 PM

Quote:

Originally Posted by flexxaeon

if it's under an if condition it's not setting a value

stfu!

....

raymor · 10-28-2011, 08:09 PM

Quote:

Originally Posted by Aric

I'm no expert, but that is wrong? You just assigned a value to $paid, which of course got rid of his PHP notices.

The PHP notices are displayed because $paid has no value set before the conditional.

Yep, $paid = false sets $paid to false.
The warning goes away because it's perfectly legal code, but it's also perfectly useless - it will always be true. To confirm, try this:

$paid = 1;
if ($paid = false) {
echo "oops, wrong answer";
}

blackmonsters · 10-28-2011, 08:19 PM

Quote:

Originally Posted by raymor

Yep, $paid = false sets $paid to false.
The warning goes away because it's perfectly legal code, but it's also perfectly useless - it will always be true. To confirm, try this:

$paid = 1;
if ($paid = false) {
echo "oops, wrong answer";
}

Exactly :

<?php

//$paid is not defined yet

if($paid = false) {
echo "paid is false";
}
//$paid was set to false above

if($paid == false) {
echo "That's really FUCKED UP!!!!!!!!!!!!!!!!!!!!!!!!!!!";
}

?>

VladS · 10-28-2011, 08:24 PM

Quote:

Originally Posted by Gsx-R

PHP Code:


			
if(!$paid)

You can also do this.

PHP Code:


			
if(!isset($paid))

FlexxAeon · 10-28-2011, 08:28 PM

haha holy shit. i apologize, i was wrong. rookie mistake. doing 3 other things. but...

Quote:

Originally Posted by blackmonsters

stfu!

....

from the dude that still uses tables??? gtfoh

blackmonsters · 10-28-2011, 08:31 PM

Quote:

Originally Posted by FlexxAeon

haha holy shit. i apologize, i was wrong. rookie mistake. doing 3 other things. but...

from the dude that still uses tables??? gtfoh

I use tables because I know what the fuck I'm doing.

Zoxxa · 10-28-2011, 08:35 PM

Your original code should work fine. The problem seems to be getting the boolean value assigned to the variable in the first place. Your error message states "Undefined variable", meaning it probably has no value. Have you echo'd out the value of $paid before the if statement to see if it has any value or is NULL?

FlexxAeon · 10-28-2011, 08:47 PM

Quote:

Originally Posted by blackmonsters

I use tables because I know what the fuck I'm doing.

Kiopa_Matt · 10-28-2011, 09:11 PM

Quote:

Originally Posted by FlexxAeon

if it's under an if condition it's not setting a value

Yes, it does. Test it and see. PHP executes what's inside the brackets first, and since it successfully assigned $paid as false, the conditional passes.

Carmen80 · 10-28-2011, 10:15 PM

Quote:

Originally Posted by Gsx-R

You can also do this.

PHP Code:


			
if(!isset($paid))

That is plain wrong. You're checking if the variable exists, not if the value is true or false.

--

The real solution:

PHP Code:


			
if(!isset($paid) || !$paid){

    if(isset($users_credits)){

        if($credits > $users_credits){

            $errors[] = 'Not enough credits for this action. Visit credits page from your profile to charge up your account!';

        }        

    } else {

        $errors[] = 'You need to login before you can watch this video';

    }    

}

You should really considering lowering your error reporting level. This should be done at the top of the script, and the script can look like this. Less messy and actually faster.

PHP Code:


			
error_reporting(E_ALL ^ E_NOTICE); // put this on top of the script, preferably inside your top configuration include file



if(!$paid){

    if(isset($users_credits)){

        if($credits > $users_credits){

            $errors[] = 'Not enough credits for this action. Visit credits page from your profile to charge up your account!';

        }        

    } else {

        $errors[] = 'You need to login before you can watch this video';

    }    

}

Tempest · 10-28-2011, 11:26 PM

Oh good lord.... lol.. The "proper" way.

Code:

if( !isset($page) || $page !== true ){

That assumes that $page will contain a proper php boolean type.. And yes, the extra = is not a typo because it doesn't just check the value but also the "type". However, if it's a 0/1 then it should just be

Code:

if( !isset($page) || $page != 1 ){

Brujah · 10-28-2011, 11:49 PM

Oh shit this is hilarious. Don't take code advice from GFY anymore!

loopardo · 10-29-2011, 12:06 AM

that was intense...

mikke · 10-29-2011, 03:35 AM

Code:

if(empty($paid)){
    if(isset($users_credits)){
        if($credits > $users_credits){
            $errors[] = 'Not enough credits for this action. Visit credits page from your profile to charge up your account!';
        }        
    } else {
        $errors[] = 'You need to login before you can watch this video';
    }    
}

also..

Code:

$smarty->assign('paid', !empty($paid)?$paid:false);

grumpy · 10-29-2011, 04:23 AM

thats a lot of wrong adivce, next time ask you quetsion at www.stackoverflow.com

Emil · 10-29-2011, 04:31 AM

Quote:

Originally Posted by marlboroack

PHP Code:


			
my cock is huge

Doesn't seem to work.

mafia_man · 10-29-2011, 01:12 PM

Quote:

Originally Posted by Gsx-R

You can also do this.

PHP Code:


			
if(!isset($paid))

The only guy on the thread who knows what he is talking about.

raymor · 10-29-2011, 05:01 PM

Quote:

Originally Posted by Brujah

Oh shit this is hilarious. Don't take code advice from GFY anymore!

Hey it's about like us circa 1997.

Mamassita · 10-30-2011, 11:34 PM

Damn guys i wont buy any shit you made...

Where's konrad

Solace · 11-29-2011, 08:54 PM

First time I have seen code tags used here

biskoppen · 11-29-2011, 10:07 PM

I'm just here for the cocks

FlexxAeon · 11-29-2011, 10:26 PM

noooooo my bane is back from the dead!

haha......wow. don't drink and code

10-28-2011, 07:13 PM	#1
Mamassita Confirmed User Join Date: Nov 2009 Posts: 252	PHP Help Needed :) Building a paid module for a custom tube script, but i'm getting this error Notice: Undefined variable: paid in /home/nakedmov/public_html/xxx/video.php on line 179 Notice: Undefined variable: paid in /home/nakedmov/public_html/xxx/video.php on line 213 Line 179 to 187 PHP Code: `if($paid == false){ if(isset($users_credits)){ if($credits > $users_credits){ $errors[] = 'Not enough credits for this action. Visit credits page from your profile to charge up your account!'; } } else { $errors[] = 'You need to login before you can watch this video'; } }` Line 213 PHP Code: `$smarty->assign('paid',$paid);` Anyone know what i've done wrong ? Thanks

10-28-2011, 07:21 PM	#2
FlexxAeon Confirmed User Industry Role: Join Date: May 2003 Posts: 3,765	dont think you use == for a boolean try: if($paid = false) __________________ flexx [dot] aeon [at] gmail

10-28-2011, 07:35 PM	#5
VladS Available for Coding Work Industry Role: Join Date: Jun 2008 Posts: 1,435	PHP Code: `if(!$paid)` __________________ <developer> MechBunny / KVS / PHP / MySQL / HTML5 / CSS3 / jQuery Email: vlad [at] dangerouscoding.com Telegram: @dangerouscoding

10-28-2011, 07:38 PM	#6
marlboroack So Fucking Banned Industry Role: Join Date: Jul 2010 Location: ☣ Posts: 9,327	PHP Code: `my cock is huge`

10-28-2011, 08:35 PM	#16
Zoxxa Confirmed User Industry Role: Join Date: Feb 2011 Location: Ontario, Canada Posts: 1,026	Your original code should work fine. The problem seems to be getting the boolean value assigned to the variable in the first place. Your error message states "Undefined variable", meaning it probably has no value. Have you echo'd out the value of $paid before the if statement to see if it has any value or is NULL? __________________ [email protected] ICQ: 269486444 ZoxEmbedTube - Build unlimited "fake" tubes with this easy 100% unencoded CMS! Last edited by Zoxxa; 10-28-2011 at 08:39 PM..

10-28-2011, 11:26 PM	#20
Tempest Too lazy to set a custom title Industry Role: Join Date: May 2004 Location: West Coast, Canada. Posts: 10,217	Oh good lord.... lol.. The "proper" way. Code: if( !isset($page) \|\| $page !== true ){ That assumes that $page will contain a proper php boolean type.. And yes, the extra = is not a typo because it doesn't just check the value but also the "type". However, if it's a 0/1 then it should just be Code: if( !isset($page) \|\| $page != 1 ){

10-28-2011, 11:49 PM	#21
Brujah Beer Money Baron Industry Role: Join Date: Jan 2001 Location: brujah / gmail Posts: 22,157	Oh shit this is hilarious. Don't take code advice from GFY anymore! __________________ Free Premium Domain Lists and Tools at Clickmojo.com For Sale: Obscenity.com

10-29-2011, 12:06 AM	#22
loopardo Registered User Industry Role: Join Date: Aug 2008 Location: around... Posts: 81	that was intense... __________________ ___

10-29-2011, 03:35 AM	#23
mikke Confirmed User Industry Role: Join Date: Jan 2010 Location: Europe Posts: 1,327	Code: if(empty($paid)){ if(isset($users_credits)){ if($credits > $users_credits){ $errors[] = 'Not enough credits for this action. Visit credits page from your profile to charge up your account!'; } } else { $errors[] = 'You need to login before you can watch this video'; } } also.. Code: $smarty->assign('paid', !empty($paid)?$paid:false); __________________ icq: 395 294 346 http://www.adultsubmitter.eu - submit any adult site to 20 directories from 1 form! now 20 domains! http://www.porndeals.eu http://www.ebonybangbros.com

10-29-2011, 04:23 AM	#24
grumpy Too lazy to set a custom title Join Date: Jan 2002 Location: Holland Posts: 9,870	thats a lot of wrong adivce, next time ask you quetsion at www.stackoverflow.com __________________ Don't let greediness blur your vision \| You gotta let some shit slide icq - 441-456-888

10-30-2011, 11:34 PM	#28
Mamassita Confirmed User Join Date: Nov 2009 Posts: 252	Damn guys i wont buy any shit you made... Where's konrad

11-29-2011, 08:54 PM	#29
Solace So Fucking Banned Industry Role: Join Date: Nov 2011 Posts: 995	First time I have seen code tags used here

11-29-2011, 10:07 PM	#30
biskoppen Confirmed User Join Date: Mar 2003 Location: Very small penis Posts: 5,809	I'm just here for the cocks __________________ Submit my videos to make bank, tons of 5 minute videos offered right here

11-29-2011, 10:26 PM	#31
FlexxAeon Confirmed User Industry Role: Join Date: May 2003 Posts: 3,765	noooooo my bane is back from the dead! haha......wow. don't drink and code __________________ flexx [dot] aeon [at] gmail Last edited by FlexxAeon; 11-29-2011 at 10:31 PM..