PHP Help Needed :)

[Mamassita]

Building a paid module for a custom tube script, but i'm getting this error


Notice: Undefined variable: paid in /home/nakedmov/public_html/xxx/video.php on line 179

Notice: Undefined variable: paid in /home/nakedmov/public_html/xxx/video.php on line 213


Line 179 to 187

PHP Code:

if($paid == false){
    if(isset($users_credits)){
        if($credits > $users_credits){
            $errors[] = 'Not enough credits for this action. Visit credits page from your profile to charge up your account!';
        }        
    } else {
        $errors[] = 'You need to login before you can watch this video';
    }    
} 


Line 213

PHP Code:

$smarty->assign('paid',$paid); 


Anyone know what i've done wrong ?

Thanks

[FlexxAeon]

dont think you use == for a boolean

try:

if($paid = false)

[Mamassita]

Originally Posted by FlexxAeon

dont think you use == for a boolean

try:

if($paid = false)

Work like a charm

Thanks a lot

[Aric]

Originally Posted by FlexxAeon

dont think you use == for a boolean

try:

if($paid = false)

I'm no expert, but that is wrong? You just assigned a value to $paid, which of course got rid of his PHP notices.

The PHP notices are displayed because $paid has no value set before the conditional.

[VladS]

PHP Code:

if(!$paid) 


[marlboroack]

PHP Code:

my cock is huge 


[FlexxAeon]

Originally Posted by Aric

I'm no expert, but that is wrong? You just assigned a value to $paid, which of course got rid of his PHP notices.

The PHP notices are displayed because $paid has no value set before the conditional.

if it's under an if condition it's not setting a value

[Mamassita]

Originally Posted by Aric

I'm no expert, but that is wrong? You just assigned a value to $paid, which of course got rid of his PHP notices.

The PHP notices are displayed because $paid has no value set before the conditional.

yeah seem there's no notices anymore

[blackmonsters]

Originally Posted by Mamassita

Work like a charm

Thanks a lot

No it didn't.

Run these two scripts :

<?php

$paid = false;
if($paid = false) {
echo "This really works!";

}
else {
echo "No No No No!";
}

?>


-------------

<?php

$paid = false;
if($paid == false) {
echo "This really works!";

}
else {
echo "No No No No!";
}

?>

[blackmonsters]

Originally Posted by flexxaeon

if it's under an if condition it's not setting a value

stfu!

....

[raymor]

Originally Posted by Aric

I'm no expert, but that is wrong? You just assigned a value to $paid, which of course got rid of his PHP notices.

The PHP notices are displayed because $paid has no value set before the conditional.

Yep, $paid = false sets $paid to false.
The warning goes away because it's perfectly legal code, but it's also perfectly useless - it will always be true. To confirm, try this:

$paid = 1;
if ($paid = false) {
echo "oops, wrong answer";
}

[blackmonsters]

Originally Posted by raymor

Yep, $paid = false sets $paid to false.
The warning goes away because it's perfectly legal code, but it's also perfectly useless - it will always be true. To confirm, try this:

$paid = 1;
if ($paid = false) {
echo "oops, wrong answer";
}

Exactly :

<?php

//$paid is not defined yet

if($paid = false) {
echo "paid is false";
}
//$paid was set to false above

if($paid == false) {
echo "That's really FUCKED UP!!!!!!!!!!!!!!!!!!!!!!!!!!!";
}

?>

[VladS]

Originally Posted by Gsx-R

PHP Code:

if(!$paid) 


You can also do this.

PHP Code:

if(!isset($paid)) 


[FlexxAeon]

haha holy shit. i apologize, i was wrong. rookie mistake. doing 3 other things. but...

Originally Posted by blackmonsters

stfu!

....

from the dude that still uses tables??? gtfoh

[blackmonsters]

Originally Posted by FlexxAeon

haha holy shit. i apologize, i was wrong. rookie mistake. doing 3 other things. but...



from the dude that still uses tables??? gtfoh

I use tables because I know what the fuck I'm doing.

[Zoxxa]

Your original code should work fine. The problem seems to be getting the boolean value assigned to the variable in the first place. Your error message states "Undefined variable", meaning it probably has no value. Have you echo'd out the value of $paid before the if statement to see if it has any value or is NULL?

[FlexxAeon]

Originally Posted by blackmonsters

I use tables because I know what the fuck I'm doing.

[Kiopa_Matt]

Originally Posted by FlexxAeon

if it's under an if condition it's not setting a value

Yes, it does. Test it and see. PHP executes what's inside the brackets first, and since it successfully assigned $paid as false, the conditional passes.

[Carmen80]

Originally Posted by Gsx-R

You can also do this.

PHP Code:

if(!isset($paid)) 


That is plain wrong. You're checking if the variable exists, not if the value is true or false.

--

The real solution:

PHP Code:

if(!isset($paid) || !$paid){
    if(isset($users_credits)){
        if($credits > $users_credits){
            $errors[] = 'Not enough credits for this action. Visit credits page from your profile to charge up your account!';
        }        
    } else {
        $errors[] = 'You need to login before you can watch this video';
    }    
} 


You should really considering lowering your error reporting level. This should be done at the top of the script, and the script can look like this. Less messy and actually faster.

PHP Code:

error_reporting(E_ALL ^ E_NOTICE); // put this on top of the script, preferably inside your top configuration include file

if(!$paid){
    if(isset($users_credits)){
        if($credits > $users_credits){
            $errors[] = 'Not enough credits for this action. Visit credits page from your profile to charge up your account!';
        }        
    } else {
        $errors[] = 'You need to login before you can watch this video';
    }    
} 


[Tempest]

Oh good lord.... lol.. The "proper" way.

if( !isset($page) || $page !== true ){

That assumes that $page will contain a proper php boolean type.. And yes, the extra = is not a typo because it doesn't just check the value but also the "type". However, if it's a 0/1 then it should just be

if( !isset($page) || $page != 1 ){

[Brujah]

Oh shit this is hilarious. Don't take code advice from GFY anymore!

[loopardo]

that was intense...

[mikke]

if(empty($paid)){
    if(isset($users_credits)){
        if($credits > $users_credits){
            $errors[] = 'Not enough credits for this action. Visit credits page from your profile to charge up your account!';
        }        
    } else {
        $errors[] = 'You need to login before you can watch this video';
    }    
}

also..

$smarty->assign('paid', !empty($paid)?$paid:false);

[grumpy]

thats a lot of wrong adivce, next time ask you quetsion at www.stackoverflow.com

[Emil]

Originally Posted by marlboroack

PHP Code:

my cock is huge 


Doesn't seem to work.

[mafia_man]

Originally Posted by Gsx-R

You can also do this.

PHP Code:

if(!isset($paid)) 


The only guy on the thread who knows what he is talking about.

[raymor]

Originally Posted by Brujah

Oh shit this is hilarious. Don't take code advice from GFY anymore!

Hey it's about like us circa 1997.

[Mamassita]

Damn guys i wont buy any shit you made...

Where's konrad

[Solace]

First time I have seen code tags used here

[biskoppen]

I'm just here for the cocks

[FlexxAeon]

noooooo my bane is back from the dead!

haha......wow. don't drink and code